[spark] Fix DefaultDatabricksRayOnSparkStartHook.on_spark_job_created #42178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeichenXu123
commented
Jan 4, 2024
| @@ -1615,11 +1615,11 @@ def ray_cluster_job_mapper(_): | |||
| ) | |||
| job_rdd = job_rdd.withResources(resource_profile) | |||
|
|
|||
| job_rdd.mapPartitions(ray_cluster_job_mapper).collect() | |||
|
|
|||
| hook_entry = _create_hook_entry(is_global=(ray_temp_dir is None)) | |||
| hook_entry.on_spark_job_created(spark_job_group_id) | |||
There was a problem hiding this comment.
Move this line to front of job_rdd.mapPartitions(ray_cluster_job_mapper).collect() because this function runs inside background thread and job_rdd.mapPartitions(ray_cluster_job_mapper).collect() will block forever until cluster or the Ray worker node is terminated.
|
CC @jjyao |
jjyao
approved these changes
Jan 4, 2024
|
|
There are conflicts. |
jjyao
approved these changes
Jan 8, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…ray-project#42178) Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix DefaultDatabricksRayOnSparkStartHook.on_spark_job_created
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.