[ci] support artifact mount for all containers #42205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-ts00
branch
2 times, most recently
from
e3ef6ec to
07520e4
Compare
aslonnie
reviewed
Jan 5, 2024
| @@ -25,8 +25,15 @@ if [ -d "/tmp/artifacts" ]; then | |||
| find /tmp/artifacts -print || true | |||
| fi | |||
|
|
|||
| echo "Creating var/ artifact directory..." | |||
| docker run --rm -v /tmp/artifacts:/artifact-mount alpine:latest /bin/sh -c 'chown -R 2000 /artifact-mount/' || true | |||
| echo "Creating artifact directory..." | |||
There was a problem hiding this comment.
move the echo into the if too?
There was a problem hiding this comment.
the echo applies for both if clauses (linux vs. windows)
ci/ray_ci/windows_container.py
Outdated
| @@ -37,3 +37,9 @@ def get_run_command_extra_args( | |||
| ) -> List[str]: | |||
| assert not gpu_ids, "Windows does not support gpu ids" | |||
| return [] | |||
|
|
|||
| def get_artifact_mount_host(self) -> str: | |||
| return "c:\\tmp\\artifacts" | |||
There was a problem hiding this comment.
nit: C:\\ (capital C) maybe?
ci/ray_ci/container.py
Outdated
Comment on lines
109
to
116
|
|
||
| @abc.abstractmethod | ||
| def get_artifact_mount_host(self) -> str: | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| def get_artifact_mount_container(self) -> str: | ||
| pass |
There was a problem hiding this comment.
make it one method that returns a tuple?
There was a problem hiding this comment.
there are some use cases later on that I need one and not the other
There was a problem hiding this comment.
in those cases you can just drop the other return value?
like:
host, _ = self.get_artifact_mount_paths()
the two values are so closely related, that they should be put together.
and they are returning just constants; there are more boilerplate code than the meat now.
There was a problem hiding this comment.
sound good, let's do that
aslonnie
approved these changes
Jan 5, 2024
Signed-off-by: can <can@anyscale.com>
can-anyscale
added a commit
that referenced
this pull request
Jan 6, 2024
#42205 moved artifact mount to the parent container class so this line is now duplicated for linux Signed-off-by: can <can@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
Support artifact mount for all containers (linux + windows) Signed-off-by: can <can@anyscale.com>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
ray-project#42205 moved artifact mount to the parent container class so this line is now duplicated for linux Signed-off-by: can <can@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support artifact mount for all containers (linux + windows)
Test: