[Cherrypick][Serve] Improve handling the websocket server disconnect scenario (#4… #42234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-project#42130) Server disconnect message is not guaranteed to be sent. So we need to handle it when finish the websocket connection. --------- Signed-off-by: Sihan Wang <sihanwang41@gmail.com>
sihanwang41
changed the title
edoakes
approved these changes
Jan 8, 2024
|
@architkulkarni @zhe-thoughts , the pr is ready. |
architkulkarni
added
release-blocker
zhe-thoughts
approved these changes
Jan 8, 2024
architkulkarni
merged commit ada0a92
into
ray-project:releases/2.9.1
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
cherrypick: #42130
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.