-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] add a initial version of CI test state machine #42280
Conversation
Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a draft? is this ready for review?
yess ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay high level, but not sure how is this going to be used.
from ray_release.test import Test, TestState | ||
|
||
|
||
class CITestStateMachine(TestStateMachine): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this different from the other test state machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI state machine: https://docs.google.com/document/d/1IVgI7LNo21bPJO8kdYTwdWwEdZr5D9VtNrabUeX8gCc/edit
Release state machine: https://docs.google.com/document/d/1hV8avu2Xl16Di3zVXyFtjuhZ8OGFDWhEt7Am319bki0/edit#heading=h.tdxb82dxifm7
I think the main difference is that CI tests have flaky state, which can be computed through automation; while release tests since they run so less frequent, the flaky state is managed by human (the unstable tag)
f"Managed by OSS Test Policy" | ||
), | ||
labels=labels, | ||
assignee="can-anyscale", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why your name is hard coded here? could you at least declare a constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally, I worry it will be spammy (so many flaky tests) so want it go to me first before triaging further; when it's stable i'll find a way to for it go directly to the oncall
Signed-off-by: can <can@anyscale.com>
138fa63
to
cc655d1
Compare
A initial version of CI test state machine with some simple movement Signed-off-by: can <can@anyscale.com>
A initial version of CI test state machine with some simple movement
Test: