Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add a initial version of CI test state machine #42280

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jan 9, 2024

A initial version of CI test state machine with some simple movement

Test:

  • CI

Signed-off-by: can <can@anyscale.com>
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale marked this pull request as ready for review January 9, 2024 23:14
@can-anyscale can-anyscale requested a review from a team as a code owner January 9, 2024 23:14
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a draft? is this ready for review?

@can-anyscale can-anyscale changed the title [ci] add a draft of CI test state machine [ci] add a initial version of CI test state machine Jan 10, 2024
@can-anyscale can-anyscale requested a review from aslonnie January 10, 2024 16:15
@can-anyscale
Copy link
Collaborator Author

yess ready for review

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay high level, but not sure how is this going to be used.

from ray_release.test import Test, TestState


class CITestStateMachine(TestStateMachine):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this different from the other test state machine?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI state machine: https://docs.google.com/document/d/1IVgI7LNo21bPJO8kdYTwdWwEdZr5D9VtNrabUeX8gCc/edit

Release state machine: https://docs.google.com/document/d/1hV8avu2Xl16Di3zVXyFtjuhZ8OGFDWhEt7Am319bki0/edit#heading=h.tdxb82dxifm7

I think the main difference is that CI tests have flaky state, which can be computed through automation; while release tests since they run so less frequent, the flaky state is managed by human (the unstable tag)

@can-anyscale can-anyscale requested a review from aslonnie January 10, 2024 19:43
f"Managed by OSS Test Policy"
),
labels=labels,
assignee="can-anyscale",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why your name is hard coded here? could you at least declare a constant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, I worry it will be spammy (so many flaky tests) so want it go to me first before triaging further; when it's stable i'll find a way to for it go directly to the oncall

Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale merged commit f3efbe2 into master Jan 10, 2024
8 of 9 checks passed
@can-anyscale can-anyscale deleted the can-ts05 branch January 10, 2024 21:54
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
A initial version of CI test state machine with some simple movement

Signed-off-by: can <can@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants