[ci][automation/3] script to run state machine #42354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
changed the title
aslonnie
reviewed
Jan 12, 2024
ci/ray_ci/BUILD.bazel
Outdated
Comment on lines
38
to
40
| name = "move_test_state", | ||
| srcs = ["move_test_state.py"], | ||
| deps = [":ray_ci_lib"], |
There was a problem hiding this comment.
just move this py_binary into the subdir, and declare rayci lib as deps?
don't include the script in the lib's source file list.
ci/ray_ci/move_test_state.py
Outdated
| @@ -0,0 +1,4 @@ | |||
| from ci.ray_ci.automation.state_machine_bot import main | |||
There was a problem hiding this comment.
just remove this wrapper. it is a script (with no test). you do not really need this wrapper.
can-anyscale
force-pushed
the
can-auto-02
branch
3 times, most recently
from
1af9025 to
eb34050
Compare
|
@aslonnie 's feedback |
aslonnie
approved these changes
Jan 12, 2024
ci/ray_ci/BUILD.bazel
Outdated
| @@ -11,7 +11,7 @@ py_library( | |||
| "build_in_docker.py", | |||
| ], | |||
| ), | |||
| visibility = ["//visibility:private"], | |||
| visibility = ["//visibility:public"], | |||
There was a problem hiding this comment.
could you change this to limit to ci/ray_ci?
Signed-off-by: can <can@anyscale.com>
can-anyscale
force-pushed
the
can-auto-02
branch
from
eb34050 to
62b9f52
Compare
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
A script to run CI state machine. Later on I'll create a buildkite job to run this nightly. Signed-off-by: can <can@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script to run CI state machine. Later on I'll create a buildkite job to run this nightly.
Test: