Skip to content

[Data] Remove 'Using Preprocessors' #44006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

[Data] Remove 'Using Preprocessors' #44006

merged 1 commit into from
Mar 14, 2024

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Mar 14, 2024

Why are these changes needed?

We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Remove 'Using Preprocessors'
021bf68 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
justinvyu
justinvyu approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch on the ray data guide which was a bit outdated.

@bveeramani bveeramani merged commit 123b87c into ray-project:master Mar 14, 2024
@bveeramani bveeramani deleted the removing-preprocessors branch March 14, 2024 19:52
angelinalg
angelinalg reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to make the recommendation more forceful.

doc/source/train/user-guides/data-loading-preprocessing.rst
Ray Data operations such as `map_batches`. See the :ref:`Ray Data Working with Pytorch guide <working_with_pytorch>` for more details.

For tabular data, we recommend using Ray Data :ref:`preprocessors <data-preprocessors>`, which implement common data preprocessing operations.
For tabular data, we recommend using Ray Data :ref:`preprocessors <preprocessor-ref>`, which implement common data preprocessing operations.
Copy link
Contributor

@angelinalg angelinalg Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tabular data, use Ray Data :ref:preprocessors <preprocessor-ref>, which implement common data preprocessing operations.

bveeramani added a commit to bveeramani/ray that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Remove 'Using Preprocessors' (ray-project#44006)
bf6b096 
We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 15, 2024
Merged
8 tasks
khluu pushed a commit that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Remove 'Using Preprocessors' (#44006) (#44042)
4a7c71c 
Cherry-pick of #44006.
We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 18, 2024
Merged
8 tasks
bveeramani added a commit that referenced this pull request Mar 19, 2024
@bveeramani
[Train] Revise recommendation to use preprocessors (#44099)
440f2c0 
#44006 (review)

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Mar 27, 2024
@bveeramani @stephanie-wang
[Train] Revise recommendation to use preprocessors (ray-project#44099)
7913eb8 
ray-project#44006 (review)

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@matthewdeng matthewdeng mentioned this pull request Oct 18, 2025
Merged
matthewdeng added a commit that referenced this pull request Oct 18, 2025
@matthewdeng
[data] remove orphaned Preprocessor doc code (#57872)
33d0a32 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in #44006.
Closes #57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
justinyeh1995 pushed a commit to justinyeh1995/ray that referenced this pull request Oct 20, 2025
@matthewdeng @justinyeh1995
[data] remove orphaned Preprocessor doc code (ray-project#57872)
7f1829a 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in ray-project#44006.
Closes ray-project#57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 22, 2025
@matthewdeng @xinyuangui2
[data] remove orphaned Preprocessor doc code (ray-project#57872)
98251db 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in ray-project#44006.
Closes ray-project#57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Signed-off-by: xgui <xgui@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Oct 23, 2025
@matthewdeng @elliot-barn
[data] remove orphaned Preprocessor doc code (#57872)
3995098 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in #44006.
Closes #57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
@matthewdeng @landscapepainter
[data] remove orphaned Preprocessor doc code (ray-project#57872)
4fab175 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in ray-project#44006.
Closes ray-project#57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
@matthewdeng
[data] remove orphaned Preprocessor doc code (ray-project#57872)
9f76397 
## Description
This removes an orphaned code file that was previously used by the
Preprocessor User Guide.

## Related issues
Corresponding User Guide was removed in ray-project#44006.
Closes ray-project#57867.

## Additional details
This test started failing because of the new `XGBoostTrainer` API
enabled by default with Ray Train V2. Rather than update the snippet,
removing this code instead.

Signed-off-by: Matthew Deng <matthew.j.deng@gmail.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelinalg angelinalg angelinalg left review comments

@justinvyu justinvyu justinvyu approved these changes

@c21 c21 c21 approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@woshiyyya woshiyyya Awaiting requested review from woshiyyya

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@omatthew98 omatthew98 Awaiting requested review from omatthew98

Assignees

@justinvyu justinvyu

@c21 c21

@angelinalg angelinalg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bveeramani @justinvyu @c21 @angelinalg