Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix broken references in Ray Tune documentation #45233

Merged
merged 2 commits into from
Jun 11, 2024
Merged

[Doc] Fix broken references in Ray Tune documentation #45233

merged 2 commits into from
Jun 11, 2024

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented May 9, 2024 •
edited
Loading

Why are these changes needed?

This PR fixes broken references found in the Tune documentation.

Related issue number

Partially addresses #39658. Blocked by #45160, will mark this as ready for review once those are merged.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray peytondmurray changed the title [WIP] [Doc] Fix broken references in Ray Tune documentation [Doc] Fix broken references in Ray Tune documentation May 9, 2024
@peytondmurray peytondmurray force-pushed the docs-fix-tune-bad-links-39658 branch from fb55dd4 to 1064b72 Compare June 3, 2024 22:35
@peytondmurray
[Doc] Fix broken references in Ray Tune documentation
54aa830 
Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray force-pushed the docs-fix-tune-bad-links-39658 branch from 1064b72 to 54aa830 Compare June 3, 2024 22:52
@peytondmurray peytondmurray marked this pull request as ready for review June 3, 2024 22:53
@peytondmurray
Add setup_wandb doc; modify link text
d3d5ea7 
Signed-off-by: pdmurray <peynmurray@gmail.com>
@matthewdeng matthewdeng enabled auto-merge (squash) June 11, 2024 20:04
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 11, 2024
@matthewdeng matthewdeng merged commit 76f5cd4 into ray-project:master Jun 11, 2024
8 checks passed
@peytondmurray peytondmurray deleted the docs-fix-tune-bad-links-39658 branch June 11, 2024 23:31
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
@peytondmurray @richardsliu
[Doc] Fix broken references in Ray Tune documentation (ray-project#45233
7e1928b 
)

This PR fixes broken references found in the Tune documentation.

Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

@hongpeng-guo hongpeng-guo Awaiting requested review from hongpeng-guo hongpeng-guo is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peytondmurray @matthewdeng @can-anyscale