-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][runtime_env] Allow full path in conda runtime env. #45550
Conversation
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
from https://docs.ray.io/en/latest/ray-core/handling-dependencies.html doesn't mention that we support full path only the name. If we want to support it, we should also update our doc. |
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Doc updated |
@angelinalg : added a clause to the doc about how to specify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nit
@@ -173,6 +173,33 @@ def get_conda_env_list() -> list: | |||
return envs | |||
|
|||
|
|||
def get_conda_info_json() -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a link or an example of the return value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
#34956 fixed a conda hanging issue by checking existence of the conda env name. However it only checks by conda env name, not path - if the user specifies an absolute path, it no longer works. This is an regression because it should support full paths without a problem.
This PR reads conda CLI for the full paths and names. A special treatment is done for
base
which is just the conda base prefix; and others are base conda_prefix/envs/name.Adds tests for both
base
and full path of it; and also name and full paths for non base envs.Fixes #44373 .