Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Remove LazyBlockList #46054

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[Data] Remove LazyBlockList #46054

merged 2 commits into from
Jun 17, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jun 14, 2024 •
edited
Loading

Why are these changes needed?

After #45860, LazyBlockList is dead code.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
9c09d66 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Appease lint
4dda574 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as draft June 14, 2024 22:20
@bveeramani bveeramani marked this pull request as ready for review June 17, 2024 17:53
@bveeramani bveeramani mentioned this pull request Jun 17, 2024
Merged
8 tasks
@bveeramani bveeramani enabled auto-merge (squash) June 17, 2024 18:54
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 17, 2024
@bveeramani bveeramani merged commit ab85dd2 into ray-project:master Jun 17, 2024
7 checks passed
bveeramani added a commit that referenced this pull request Jun 17, 2024
@bveeramani
[Data] Remove run_by_consumer parameter of ExecutionPlan (#46052)
3f36b1b 
This PR removes dead functions and parameters after #46054.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
chungen04 pushed a commit to chungen04/ray that referenced this pull request Jun 18, 2024
@bveeramani @chungen04
[Data] Remove LazyBlockList (ray-project#46054)
53be6ef 
After ray-project#45860, LazyBlockList is dead code.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
chungen04 pushed a commit to chungen04/ray that referenced this pull request Jun 18, 2024
@bveeramani @chungen04
[Data] Remove run_by_consumer parameter of ExecutionPlan (ray-pro…
f2656ca 
…ject#46052)

This PR removes dead functions and parameters after ray-project#46054.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@scottjlee scottjlee

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bveeramani @scottjlee