[RLlib] Remove default-metrics from Algorithm (tune does NOT error anymore if any stop-metric is missing).
#46200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
…ve_common_default_metrics_bc_tune_only_warns_now
sven1977
added
the
tests-ok
simonsays1980
approved these changes
Jun 26, 2024
| @@ -67,8 +67,6 @@ def __init__(self, config: AlgorithmConfig, **kwargs): | |||
|
|
|||
| # Create a MetricsLogger object for logging custom stats. | |||
| self.metrics = MetricsLogger() | |||
| # Initialize lifetime counts. | |||
| self.metrics.log_value(NUM_ENV_STEPS_SAMPLED_LIFETIME, 0, reduce="sum") | |||
There was a problem hiding this comment.
Don't we need the lifetime counts in the EnvRunner anymore? Are they initialized elsewhere?
There was a problem hiding this comment.
We now call self.metrics.peek((.. some key))with arg default=0, so no initialization is necessary anymore.
sven1977
deleted the
remove_common_default_metrics_bc_tune_only_warns_now
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default-metrics from
Algorithm(tune does NOT error anymore if any stop-metric is missing).config.always_attach_evaluation_results(no longer needed).Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.