Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow env setup logger encoding #46242

Merged
merged 6 commits into from
Jun 29, 2024

Conversation

GeneDer
Copy link
Contributor

@GeneDer GeneDer commented Jun 25, 2024

Why are these changes needed?

Added RAY_LOGGING_CONFIG_ENCODING env to config Ray logger encoding even when ray.init isn't called with a logging config.

Will follow up with a product PR to enable it for Services.

Related issue number

Closes #46125

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer added the go add ONLY when ready to merge, run all tests label Jun 25, 2024
@GeneDer GeneDer changed the title Allow env setup default logger [Core] Allow env setup default logger Jun 25, 2024
[
{
"env_vars": {
"RAY_SETUP_DEFAULT_LOGGER": "1",
Copy link
Contributor Author

@GeneDer GeneDer Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks kinda odd, but this is pretty much the same test as the one above except this env is set here and that one line 254 ray.init isn't called with logging config

@GeneDer GeneDer requested review from kevin85421 and jjyao June 25, 2024 06:11
@GeneDer GeneDer added enhancement Request for new feature and/or capability core Issues that should be addressed in Ray Core labels Jun 25, 2024
@GeneDer GeneDer marked this pull request as ready for review June 25, 2024 06:11
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer
Copy link
Contributor Author

GeneDer commented Jun 27, 2024

@jjyao if this also LGTY can you help to merge it so I can follow up with the product change 🙏

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer GeneDer changed the title [Core] Allow env setup default logger [Core] Allow env setup logger encoding Jun 27, 2024
@jjyao jjyao merged commit b359c97 into ray-project:master Jun 29, 2024
6 checks passed
@GeneDer GeneDer deleted the allow-env-setup-default-logger branch July 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs] Integrate Serve's logger with Core's structured logger
3 participants