-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Allow env setup logger encoding #46242
Merged
jjyao
merged 6 commits into
ray-project:master
from
GeneDer:allow-env-setup-default-logger
Jun 29, 2024
Merged
[Core] Allow env setup logger encoding #46242
jjyao
merged 6 commits into
ray-project:master
from
GeneDer:allow-env-setup-default-logger
Jun 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <e870252314@gmail.com>
GeneDer
changed the title
Allow env setup default logger
[Core] Allow env setup default logger
Jun 25, 2024
GeneDer
commented
Jun 25, 2024
python/ray/tests/test_logging_2.py
Outdated
[ | ||
{ | ||
"env_vars": { | ||
"RAY_SETUP_DEFAULT_LOGGER": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks kinda odd, but this is pretty much the same test as the one above except this env is set here and that one line 254 ray.init
isn't called with logging config
GeneDer
added
enhancement
Request for new feature and/or capability
core
Issues that should be addressed in Ray Core
labels
Jun 25, 2024
kevin85421
reviewed
Jun 26, 2024
Signed-off-by: Gene Su <e870252314@gmail.com>
kevin85421
approved these changes
Jun 26, 2024
@jjyao if this also LGTY can you help to merge it so I can follow up with the product change 🙏 |
Signed-off-by: Gene Su <e870252314@gmail.com>
GeneDer
changed the title
[Core] Allow env setup default logger
[Core] Allow env setup logger encoding
Jun 27, 2024
jjyao
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Issues that should be addressed in Ray Core
enhancement
Request for new feature and/or capability
go
add ONLY when ready to merge, run all tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Added
RAY_LOGGING_CONFIG_ENCODING
env to config Ray logger encoding even whenray.init
isn't called with a logging config.Will follow up with a product PR to enable it for Services.
Related issue number
Closes #46125
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.