-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Cleanup examples folder 17: Add example for custom RLModule with an LSTM. #46276
Merged
sven1977
merged 10 commits into
ray-project:master
from
sven1977:cleanup_examples_folder_17_custom_rl_module_w_lstm
Jun 27, 2024
Merged
[RLlib] Cleanup examples folder 17: Add example for custom RLModule with an LSTM. #46276
sven1977
merged 10 commits into
ray-project:master
from
sven1977:cleanup_examples_folder_17_custom_rl_module_w_lstm
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nup_examples_folder_17_custom_rl_module_w_lstm
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
June 26, 2024 12:23
…nup_examples_folder_17_custom_rl_module_w_lstm
simonsays1980
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
def setup(self): | ||
"""Use this method to create all the model components that you require. | ||
|
||
Feel free to access the following useful properties in this class: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add this super neat docstrings also to the classes I have written. Really good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder 17: Add example for custom RLModule with an LSTM.
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.