[RLlib] Add systematic APPO learning tests to CI. Combinations of [1CPU|2CPUs|1GPU|2GPUs] + [single-agent|multi-agent] #46299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
Jun 27, 2024
| tags = ["team:rllib", "exclusive", "learning_tests", "torch_only", "learning_tests_cartpole", "learning_tests_discrete", "learning_tests_pytorch_use_all_core"], | ||
| size = "large", | ||
| srcs = ["tuned_examples/appo/cartpole_appo.py"], | ||
| args = ["--as-test", "--enable-new-api-stack", "--num-gpus=2"] |
There was a problem hiding this comment.
Do we need to ensure resources of enough CPUs? --num-cpus=4?
There was a problem hiding this comment.
Good question. I think 4 CPUs is the default, so in this case, it should be fine:
2 for the EnvRunners
1 for the single Learner
1 for the main process
…ematic_ci_learning_tests_for_appo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add systematic APPO learning tests to CI.
Combinations of [1CPU|2CPUs|1GPU|2GPUs] + [single-agent|multi-agent]
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.