Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Task status should start with PENDING_ARGS_AVAIL when retry #46494

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[Core] Task status should start with PENDING_ARGS_AVAIL when retry #46494

merged 1 commit into from
Jul 9, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 9, 2024

Why are these changes needed?

A new task attempt should always starts with PENDING_ARGS_AVAIL. We did it for MarkTaskRetryOnResubmit but not for MarkTaskRetryOnFailed

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Task status should start with PENDING_ARGS_AVAIL when retry
cbfae9f 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from rickyyx July 9, 2024 04:56
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 9, 2024
rickyyx
rickyyx approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjyao jjyao merged commit c9b14d7 into ray-project:master Jul 9, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/sta branch July 9, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

Assignees

@rickyyx rickyyx

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @rickyyx