Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Emit total lineage bytes metric #46725

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 20, 2024

Why are these changes needed?

Ray only store task specs for lineage reconstruction up to max_lineage_bytes config and if the limit is reached, some task specs will be evicted and related objects can no longer be reconstructed. Emitting the metric showing the total memory used for storing task specs so that we can better tune the limit.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao changed the title Serve microbenchmarks perf regression [Core] Emit total lineage bytes metric Jul 26, 2024
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 26, 2024
@jjyao jjyao marked this pull request as ready for review July 26, 2024 00:08
@jjyao jjyao requested a review from a team as a code owner July 26, 2024 00:08
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the Grafana chart look like?
Will it break down the linage size by workers?

@jjyao
Copy link
Collaborator Author

jjyao commented Jul 26, 2024

Will it break down the linage size by workers?

Yes, worker id is a metric tag

@jjyao
Copy link
Collaborator Author

jjyao commented Jul 26, 2024

Screenshot 2024-07-25 at 11 47 29 PM

@jjyao jjyao merged commit f9b36da into ray-project:master Jul 26, 2024
5 of 6 checks passed
@jjyao jjyao deleted the jjyao/servv branch July 26, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants