Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Cleanup examples folder 22: Add 2 (count-based) curiosity examples. #46737

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jul 22, 2024

Cleanup examples folder 22: Add 2 (count-based) curiosity examples:

  • Simple obs-count (solving an almost impossible FrozenLake env).
  • Euclidian distance (solving MountainCar-v0)

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice example!

from ray.rllib.utils.typing import EpisodeType


class CountBasedCuriosity(ConnectorV2):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great example!

"is_slippery": False,
# Use this hard-to-solve 8x8 map with lots of holes (H) to fall into and only very
# few valid paths from the starting state (S) to the goal state (G).
"desc": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good old FrozenLake :D - perfect for this example

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) July 23, 2024 10:52
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 23, 2024
@sven1977 sven1977 merged commit c1095c7 into ray-project:master Jul 23, 2024
6 of 7 checks passed
@sven1977 sven1977 deleted the cleanup_examples_folder_22_count_based_curiosity branch July 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants