Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix bug in BC config (automatically setting new API stack related settings). #46799

Conversation

sven1977
Copy link
Contributor

Fix bug in BC config (automatically setting new API stack related settings).

The BCConfig c'tor would automatically set RLModule+Learner to True, if EnvRunner+Connector is True.

The desired behavior is to issue an error.
Also, it's not desired to have the any RLlib algo-config class magically set certain settings w/o warning the user or throwing an error.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) July 26, 2024 07:42
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 26, 2024
@sven1977 sven1977 merged commit fc65981 into ray-project:master Jul 26, 2024
6 checks passed
@sven1977 sven1977 deleted the fix_bc_bug_related_to_new_api_stack_config branch July 27, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants