[core][adag] Fix for asyncio outputs #46845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisearch42
approved these changes
Jul 29, 2024
|
what was the error message? I am curious if it is the same error I've seen while I developed |
rkooo567
approved these changes
Jul 29, 2024
| @@ -1431,7 +1431,9 @@ async def execute_async( | |||
| fut = asyncio.Future() | |||
| await self._fut_queue.put(fut) | |||
|
|
|||
| return CompiledDAGFuture(self, self._execution_index, fut) | |||
| fut = CompiledDAGFuture(self, self._execution_index, fut) | |||
| self._execution_index += 1 | |||
There was a problem hiding this comment.
is it related to this PR?
There was a problem hiding this comment.
Just a fix for UX - the execution index here is only used for the __str__ representation of the future, but it always said execution_index=0 before :)
Ah yeah the error message was this: Exception ignored in: <function CompiledDAGRef.__del__ at 0x7fbcfb452790>
Traceback (most recent call last):
File "/home/swang/ray/python/ray/experimental/compiled_dag_ref.py", line 77, in __del__
if not self._ray_get_called:
AttributeError: 'CompiledDAGFuture' object has no attribute '_ray_get_called' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When asyncio interface is used, we do not need to call
geton the underlying objects because this is already done by a background thread. Therefore, when a CompiledDAGFuture goes out of scope, we should just let the underlying future go out of scope instead of trying to callgetlike we do for CompiledDAGRefs.When testing locally, I found that without these changes, the program would produce errors when a CompiledDAGFuture went out of scope because it tried to call CompiledDAGRef.del. I'm not sure why these don't appear when running the existing tests though.
Closes #46766.