Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify behavior of placement_group_capture_child_tasks in docs #46885

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Clarify behavior of placement_group_capture_child_tasks in docs #46885

merged 5 commits into from
Aug 5, 2024

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Jul 30, 2024

Explicitly specify that placement_group_capture_child_tasks value needs to be set for every actor and the value is not inherited from its parent actor.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam
clarify pg behavior in docs
6444343 
Signed-off-by: Amog Kamsetty <amogkamsetty@gmail.com>
@amogkam amogkam requested a review from a team as a code owner July 30, 2024 22:24
@rkooo567
Copy link
Contributor

cc @angelinalg

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 30, 2024
@rkooo567
Copy link
Contributor

rkooo567 commented Aug 2, 2024

doc build failure @amogkam

@can-anyscale
Copy link
Collaborator

please rebase, the readsthedoc build is fixed on lastest master, thankks

angelinalg
angelinalg approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

doc/source/ray-core/scheduling/placement-group.rst Outdated Show resolved Hide resolved
doc/source/ray-core/scheduling/placement-group.rst Outdated Show resolved Hide resolved
@jjyao @angelinalg
Apply suggestions from code review
9675a91 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao enabled auto-merge (squash) August 5, 2024 06:39
@jjyao jjyao merged commit 06d56fa into master Aug 5, 2024
6 checks passed
@jjyao jjyao deleted the pg-docs-clarify branch August 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@jjyao jjyao

@rkooo567 rkooo567

@angelinalg angelinalg

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amogkam @rkooo567 @can-anyscale @angelinalg @jjyao