[RLlib; Offline RL] Add tests for OfflineSingleAgentEnvRunner.
#47133
+222
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
sven1977
changed the title
OfflineSingleAgentEnvRunner.OfflineSingleAgentEnvRunner.
sven1977
requested review from
sven1977 and
ArturNiederfahrenhorst
as code owners
…to the docstrings in 'AlgorithmConfig' in regard to column compression. Signed-off-by: simonsays1980 <simon.zehnder@gmail.com>
sven1977
reviewed
Aug 15, 2024
| @@ -1598,6 +1598,13 @@ py_test( | |||
| srcs = ["offline/estimators/tests/test_dr_learning.py"], | |||
| ) | |||
|
|
|||
| py_test( | |||
There was a problem hiding this comment.
awesome!
super nit: let's keep test cases alphabetically ordered (within their category), so let's move this below the next record (test_offline_data).
sven1977
reviewed
Aug 15, 2024
| @@ -2456,7 +2456,9 @@ def offline_data( | |||
| to define the output data format when recording. | |||
| input_compress_columns: What input columns are compressed with LZ4 in the | |||
| input data. If data is stored in `RLlib`'s `SingleAgentEpisode` ( | |||
| `MultiAgentEpisode` not supported, yet). | |||
| `MultiAgentEpisode` not supported, yet). Note, | |||
| `rllib.core.columns.Columns.OBS` will also try to decompress | |||
There was a problem hiding this comment.
Awesome. Thanks for clarifying this for the users. Makes perfect sense that they won't have to specify NEXT_OBS explicitly.
sven1977
reviewed
Aug 15, 2024
| @@ -2513,7 +2515,8 @@ def offline_data( | |||
| output_config: Arguments accessible from the IOContext for configuring | |||
| custom output. | |||
| output_compress_columns: What sample batch columns to LZ4 compress in the | |||
| output data. | |||
| output data. Note, `rllib.core.columns.Columns.OBS` will also compress | |||
sven1977
reviewed
Aug 15, 2024
| @@ -193,7 +193,7 @@ def sample( | |||
| getattr(samples_ds, self.output_write_method)( | |||
| path.as_posix(), **self.output_write_method_kwargs | |||
| ) | |||
| logger.info("Wrote samples to storage.") | |||
| logger.info(f"Wrote samples to storage at {path}") | |||
sven1977
reviewed
Aug 15, 2024
| @@ -250,7 +250,6 @@ def convert(sample, space): | |||
| return sample | |||
|
|
|||
| episodes = [] | |||
| # TODO (simon): Give users possibility to provide a custom schema. | |||
sven1977
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Awesome PR! Thanks for following up on these test cases @simonsays1980 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds tests to check, if recording of agents works properly. Recording is managed by the
OfflineSingleAgentEnvRunnerthat usesray.datato write files to disk.This test suite tests:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.