Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Handle errors in SplitCoordinator when generating a new epoch #47176

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Aug 16, 2024

Why are these changes needed?

Previously if an error happens while launching the executor while generating a new epoch, we don't handle the error properly, thus users will get a confusing error. And the actual root cause will be hidden.

E                         File "/Users/chenh/code/ray/python/ray/data/_internal/iterator/stream_split_iterator.py", line 197, in start_epoch
E                           epoch_id = self._barrier(split_idx)
E                         File "/Users/chenh/code/ray/python/ray/data/_internal/iterator/stream_split_iterator.py", line 285, in _barrier
E                           assert self._output_iterator is not None
E                       AssertionError

This PR solves this issue by storing the error and re-raise it from all threads.

Related issue number

Closes #45225

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen raulchen enabled auto-merge (squash) August 16, 2024 19:53
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 16, 2024
…5226)"

This reverts commit adc18b8.

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@github-actions github-actions bot disabled auto-merge August 16, 2024 20:30
@raulchen raulchen enabled auto-merge (squash) August 16, 2024 20:33
@raulchen raulchen merged commit ee3625d into ray-project:master Aug 16, 2024
6 checks passed
@raulchen raulchen deleted the handle-stream-split-error branch August 16, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data][train] Bug in SplitCoordinator: "assert self._output_iterator is not None"
3 participants