Fix rlib test failure caused by deadlock #4718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add lock in
fetch_and_execute_function_to_run
of import_thread.py.import_thread.py
and main thread may both callpickle.loads
to import a certain class. If they do the importing at the same time, there will be exception. Thus, the lock is necessary.Related issue number
https://travis-ci.com/ray-project/ray/jobs/196114212
#4499
Linter
scripts/format.sh
to lint the changes in this PR.