-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Enhance CI (increase parallelism; remove tf2-eager-tracing learning tests) #47197
[RLlib] Enhance CI (increase parallelism; remove tf2-eager-tracing learning tests) #47197
Conversation
.buildkite/rllib.rayci.yml
Outdated
instance_type: gpu-large | ||
commands: | ||
- bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib | ||
--workers "$${BUILDKITE_PARALLEL_JOB_COUNT}" --worker-id "$${BUILDKITE_PARALLEL_JOB}" | ||
--parallelism-per-worker 2 | ||
--gpus 4 | ||
--gpus 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 4 still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
and delete this test as well https://github.com/ray-project/ray/blob/master/ci/ray_ci/test_linux_tester_container.py#L82, sorry about this |
…nce_cleanup_rllib_ci_tests
Signed-off-by: sven1977 <svenmika1977@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this also remove the tf2
tests for the old stack CQL/SAC?
We only remove tf2 + eager tracing tests here. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance CI (increase parallelism; remove tf2-eager-tracing learning tests)
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.