Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Enhance CI (increase parallelism; remove tf2-eager-tracing learning tests) #47197

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 19, 2024

Enhance CI (increase parallelism; remove tf2-eager-tracing learning tests)

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) August 19, 2024 13:12
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 19, 2024
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge August 19, 2024 13:30
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 requested a review from a team as a code owner August 19, 2024 19:02
instance_type: gpu-large
commands:
- bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib
--workers "$${BUILDKITE_PARALLEL_JOB_COUNT}" --worker-id "$${BUILDKITE_PARALLEL_JOB}"
--parallelism-per-worker 2
--gpus 4
--gpus 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 4 still

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@can-anyscale
Copy link
Collaborator

and delete this test as well https://github.com/ray-project/ray/blob/master/ci/ray_ci/test_linux_tester_container.py#L82, sorry about this

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this also remove the tf2 tests for the old stack CQL/SAC?

@sven1977
Copy link
Contributor Author

LGTM. Does this also remove the tf2 tests for the old stack CQL/SAC?

We only remove tf2 + eager tracing tests here.
tf2 + static-graph tests remain in place for now ...

@sven1977
Copy link
Contributor Author

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 20, 2024
@sven1977 sven1977 enabled auto-merge (squash) August 20, 2024 11:03
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sven1977 sven1977 merged commit e66ebc3 into ray-project:master Aug 20, 2024
6 checks passed
@sven1977 sven1977 deleted the enhance_cleanup_rllib_ci_tests branch August 21, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants