Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] [Release Test] Add AWS ACCESS_DENIED as retryable exception for multi-node Data+Train benchmarks #47232

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[Data] [Release Test] Add AWS ACCESS_DENIED as retryable exception for multi-node Data+Train benchmarks #47232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68358e4
add access denied retry
scottjlee Aug 20, 2024
4cedbb3
fix msg format
scottjlee Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion release/nightly_tests/dataset/multi_node_train_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,13 @@ def __iter__(self):
def benchmark_code(
args,
):
ctx = ray.data.DataContext.get_current()
# This release test runs into ACCESS_DENIED errors fairly often.
# We add ACCESS_DENIED as a retryable exception type to avoid flakiness.
# See for more details: https://github.com/ray-project/ray/issues/47230
ctx.retried_io_errors.append("AWS Error ACCESS_DENIED")

if args.target_max_block_size_mb is not None:
ctx = ray.data.DataContext.get_current()
ctx.target_max_block_size = args.target_max_block_size_mb * 1024 * 1024

cache_input_ds = args.cache_input_ds
Expand Down