[RLlib] Disable multi-agent env check in MultiAgentEnvRunner, if configured (config.disable_env_checking is True). #47271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
simonsays1980
approved these changes
Aug 22, 2024
| @@ -1562,6 +1562,11 @@ def environment( | |||
| clip_actions: If True, the RLlib default ModuleToEnv connector will clip | |||
| actions according to the env's bounds (before sending them into the | |||
| `env.step()` call). | |||
| disable_env_checking: Disable RLlib's env checks after a gymnasium.Env | |||
There was a problem hiding this comment.
Didn't we remove this flag some time ago? :)
There was a problem hiding this comment.
We had deprecated it. But now that we are actually still checking the MultiAgentEnv in the new stack, we just de-deprecate it here and make it useful again :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable multi-agent env check in MultiAgentEnvRunner, if configured (config.disable_env_checking is True).
disable_env_checkingsetting, b/c it's used again to block the multi-agent env check.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.