[Data] Get AWS credentials with boto #47352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <sjl@anyscale.com>
aslonnie
approved these changes
Aug 27, 2024
alexeykudinkin
approved these changes
Aug 27, 2024
raulchen
approved these changes
Aug 27, 2024
| @@ -505,6 +505,21 @@ def split_input_files_per_worker(args): | |||
| ] | |||
|
|
|||
|
|
|||
| def get_s3fs_with_boto_creds(): | |||
There was a problem hiding this comment.
Can you create a GH issue, and point users to this workaround?
And can you add a comment here on why doing this, as well as the downsides of this workaround?
IIUC, the downsides are:
- credentials obtained from the driver may not work on remote nodes.
- this approach doesn't handle expiration.
There was a problem hiding this comment.
linked to this existing issue here
Signed-off-by: Scott Lee <sjl@anyscale.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 12, 2024
## Why are these changes needed? To reduce flakiness of the `multi_node_train_benchmark.py` release tests (e.g. `read_images_train_1_gpu_5_cpu.aws`) caused by `AWS Error ACCESS_DENIED`, we get filesystem object using `boto3` and pass it to `read_parquet()` instead. We suspect the root cause of the AWS error stems from `pyarrow.fs`, but need to confirm. See below for two release test runs without such errors. ## Related issue number Closes ray-project#47337 ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [x] Release tests - https://buildkite.com/ray-project/release/builds/21708 - https://buildkite.com/ray-project/release/builds/21742 - [ ] This PR is not tested :( --------- Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To reduce flakiness of the
multi_node_train_benchmark.pyrelease tests (e.g.read_images_train_1_gpu_5_cpu.aws) caused byAWS Error ACCESS_DENIED, we get filesystem object usingboto3and pass it toread_parquet()instead. We suspect the root cause of the AWS error stems frompyarrow.fs, but need to confirm. See below for two release test runs without such errors.Related issue number
Closes #47337
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.