Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix ray_unintentional_worker_failures_total to only count unintentional worker failures #47368

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[Core] Fix ray_unintentional_worker_failures_total to only count unintentional worker failures #47368

merged 3 commits into from
Aug 28, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 27, 2024

Why are these changes needed?

Currently ray_unintentional_worker_failures_total counts both intentional and unintentional worker failures

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Fix ray_unintentional_worker_failures_total to only count unintention…
c082672 
…al worker failures

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from a team as a code owner August 27, 2024 22:06
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 27, 2024
@jjyao
up
0408a65 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
rkooo567
rkooo567 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comment.

src/ray/gcs/gcs_server/gcs_worker_manager.cc Outdated Show resolved Hide resolved
@jjyao
up
957837b 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao merged commit d9d74fa into ray-project:master Aug 28, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/uninte branch August 28, 2024 16:36
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
@jjyao @ujjawal-khare
[Core] Fix ray_unintentional_worker_failures_total to only count unin…
e957993 
…tentional worker failures (ray-project#47368)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@rkooo567 rkooo567

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @rkooo567