Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] add a comment explaining the bundling behavior for map_batches with default batch_size #47433

Merged
merged 1 commit into from
Aug 31, 2024
Merged

[data] add a comment explaining the bundling behavior for map_batches with default batch_size #47433

merged 1 commit into from
Aug 31, 2024

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Aug 30, 2024 •
edited
Loading

Why are these changes needed?

When batch_size is not set, input blocks are will be not bundled up.
Add a comment explaining this.
See #29971 and #47363 (comment)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
comment
7b1b1ec 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen changed the title [data] add a comment explaining the bundling behavior for map_batches when batch_size is not set [data] add a comment explaining the bundling behavior for map_batches with default batch_size Aug 30, 2024
@raulchen raulchen enabled auto-merge (squash) August 30, 2024 21:32
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 30, 2024
@raulchen raulchen merged commit 00282f6 into ray-project:master Aug 31, 2024
6 checks passed
@raulchen raulchen deleted the map-batches-bundle-comment branch September 3, 2024 20:36
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 12, 2024
@raulchen @ujjawal-khare
[data] add a comment explaining the bundling behavior for map_batches…
545d1b3 
… with default batch_size (ray-project#47433)

When batch_size is not set, input blocks are will be not bundled up.
Add a comment explaining this.
See ray-project#29971 and
ray-project#47363 (comment)

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@amogkam amogkam Awaiting requested review from amogkam

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulchen @scottjlee