Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib; Off-policy] Add episode sampling to EpisodeReplayBuffer. #47500

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Sep 5, 2024

Why are these changes needed?

The EpisodeReplayBuffer is still sampling batches, i.e. dicts. This PR proposes a way to add episode sampling to the buffer such that the buffer can be used in the same form as the other episode buffers. This is also a preliminary for using buffers in the OfflinePreLearner.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980 simonsays1980 marked this pull request as ready for review September 5, 2024 09:26
@simonsays1980 simonsays1980 self-assigned this Sep 5, 2024
@sven1977
Copy link
Contributor

sven1977 commented Sep 5, 2024

Awesome unification PR! This opens the door to a DQfD style mixing of offline and off-policy RL!

Dumb question: Would this already work even if the PrioritizedEpisodeReplayBuffer doesn't support this flag yet?

@simonsays1980
Copy link
Collaborator Author

Awesome unification PR! This opens the door to a DQfD style mixing of offline and off-policy RL!

Dumb question: Would this already work even if the PrioritizedEpisodeReplayBuffer doesn't support this flag yet?

Thanks @sven1977! I guess that mixing would be possible even before? Wouldn't it? We just use DQN and add a dataset, then sample from the buffer and let the OfflinePreLearner return episodes instead of MultiAgentBatch to be able to mix the two episode lists. Then pass the lists to the trainer. We cannot make use of the offline pipeline because we need to add continuously episodes to the off-policy buffer and this one should exist over the full course of training.

The PrioritizedEpisodeReplayBuffer did already support the episode sampling and could be used in the OfflinePreLearner. Imo this, however, would somehow bias offline learning because we would filter data between offline data and learner. But, if a user wants to have a prioritized sampling from her offline data, we could support this out-of-the-box :) Will add a buffer definition to the AlgorithmConfig of offline().

@sven1977 sven1977 changed the title [RLlib; Off-policy] - Add episode sampling to EpisodeReplayBuffer. [RLlib; Off-policy] Add episode sampling to EpisodeReplayBuffer. Sep 5, 2024
@simonsays1980 simonsays1980 added rllib RLlib related issues rllib-offline-rl Offline RL problems labels Sep 6, 2024
@sven1977 sven1977 enabled auto-merge (squash) September 6, 2024 13:09
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Sep 6, 2024
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks a ton @simonsays1980 !!

@sven1977 sven1977 merged commit 5c70d96 into ray-project:master Sep 6, 2024
7 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
…ay-project#47500)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
@simonsays1980 simonsays1980 deleted the replay-buffers-add-episode-sampling-to-episode-buffer branch November 22, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-offline-rl Offline RL problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants