re-phrase the streaming executor current usage string #47515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofianhnaide
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
raulchen,
stephanie-wang and
omatthew98
as code owners
scottjlee
approved these changes
Sep 6, 2024
|
is there already a GH issue for the ray core feature? we can link it here and/or leave a |
matthewdeng
reviewed
Sep 6, 2024
Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com>
scottjlee
approved these changes
Sep 18, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…ject#47515) ## Why are these changes needed? The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. ray-project#46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing. Before <img width="1249" alt="image" src="https://github.com/user-attachments/assets/049ea096-a87f-4767-ba04-6d00d7c2755d"> After <img width="1248" alt="image" src="https://github.com/user-attachments/assets/cb74c0dc-1f33-4b22-b31c-e83df2a5d408"> This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task. <img width="1493" alt="image" src="https://github.com/user-attachments/assets/9315b884-3e61-4b32-8400-7f76e15b6a4b"> In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment). ## Related issue number ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Sofian Hnaide <103539032+sofianhnaide@users.noreply.github.com> Co-authored-by: scottjlee <sjl@anyscale.com> Co-authored-by: matthewdeng <matt@anyscale.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The progress bar for ray data could still end up showing higher utilization of what the cluster currently have. #46729 was the first attempt to fix it which addressed the issue in static clusters, but we still have that issue for clusters that autoscales. This change simply rephrase the string so it is less confusing.
Before
After
This comes from the fact that operators don't track the task state (and currently ray core does not even provide that api). Which means Ray data operators does not know if the task is assigned to a node or not, so once the task is submitted to ray it is marked active even if it is pending a node assignment. The dashboard does better here since it does have extra information from the task.
In the future we can visit adding the core api for remote state reporting and allowing operators to provide more detailed state (active, pending_scheduled, pending_node_assignment).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.