[core][dashboard] Add Pg Id and Format Required Resources in /logical/actors Response #47754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the REST API response that the dashboard calls Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
MengjinYan
force-pushed
the
issue-45658
branch
from
ff27a56
to
49a9cbf
Compare
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
rynewang
approved these changes
Sep 20, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…/actors Response (ray-project#47754) ## Problem to Solve In issue ray-project#45658, we found that the placement group id and the required resources are not displayed correctly in the actor UI tab in the dashboard. To be specific: * The "Placement group ID" column content is missing * The "Required resources" column shows resources with pg ids and bundle entries as well <img width="2532" alt="Screenshot 2024-09-18 at 9 49 27 AM" src="https://github.com/user-attachments/assets/1bdd3bd3-6216-459d-87ba-b28de8f3367e"> ## Root Cause With investigation, we found the root cause of the issue is that: * The dashboard calls "/logical/actors" to get the actor information to display * The response content of the above REST API doesn't contain the placement group id field and the required resources are not formatted correctly * Therefore, the dashboard fails to the display the corresponding content correctly ## Changes in the PR * Include `placementGroupId` in the keys to be translated/preserved in the `actor_table_data_to_dict` function so that the pg id can be included in the content of the REST API response * Leverage the `parse_pg_formatted_resources_to_original` function to reformatted the required resources before sending the REST API response * Test logic added in `test_actors` tests to verify the logic of setting the placement group id as well as the correctly formatted required resources Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem to Solve
In issue #45658, we found that the placement group id and the required resources are not displayed correctly in the actor UI tab in the dashboard. To be specific:
Root Cause
With investigation, we found the root cause of the issue is that:
Changes in the PR
placementGroupIdin the keys to be translated/preserved in theactor_table_data_to_dictfunction so that the pg id can be included in the content of the REST API responseparse_pg_formatted_resources_to_originalfunction to reformatted the required resources before sending the REST API responsetest_actorstests to verify the logic of setting the placement group id as well as the correctly formatted required resourcesRelated issue number
#45658
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.