Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response injection #47810

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix response injection #47810

merged 3 commits into from
Oct 29, 2024

Conversation

richo-anyscale
Copy link
Contributor

Why are these changes needed?

Previously the error message was injected directly as the HTTP status message

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@anyscalesam anyscalesam added P1 Issue that should be fixed within a few weeks security The issue or proposal related to security labels Sep 24, 2024
@anyscalesam anyscalesam added the dashboard Issues specific to the Ray Dashboard label Sep 24, 2024
@pcmoritz pcmoritz enabled auto-merge (squash) October 16, 2024 22:59
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 16, 2024
@richo-anyscale
Fix response injection
e24d93f 
Signed-off-by: Richo Healey <richo@anyscale.com>
@richo-anyscale
Remove reason argument to rest_response
bfbcc77 
Signed-off-by: Richo Healey <richo@anyscale.com>
@github-actions github-actions bot disabled auto-merge October 28, 2024 20:30
@richo-anyscale richo-anyscale force-pushed the richo/header-injection branch 3 times, most recently from 7050efb to 520d49c Compare October 28, 2024 21:12
@richo-anyscale
Fix tests for log_list
b64f9e9 
Signed-off-by: Richo Healey <richo@anyscale.com>
@rynewang rynewang merged commit 2e1b0f6 into master Oct 29, 2024
5 checks passed
@rynewang rynewang deleted the richo/header-injection branch October 29, 2024 17:49
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@richo-anyscale @Jay-ju
Fix response injection (ray-project#47810)
fd1eea8 
Previously the error message was injected directly as the HTTP status
message

Signed-off-by: Richo Healey <richo@anyscale.com>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@richo-anyscale @JP-sDEV
Fix response injection (ray-project#47810)
c03e028 
Previously the error message was injected directly as the HTTP status
message

Signed-off-by: Richo Healey <richo@anyscale.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@richo-anyscale @mohitjain2504
Fix response injection (ray-project#47810)
d16689a 
Previously the error message was injected directly as the HTTP status
message

Signed-off-by: Richo Healey <richo@anyscale.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwguo alanwguo alanwguo approved these changes

Assignees
No one assigned
Labels
dashboard Issues specific to the Ray Dashboard go add ONLY when ready to merge, run all tests P1 Issue that should be fixed within a few weeks security The issue or proposal related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richo-anyscale @alanwguo @rynewang @anyscalesam