Fix rpdb.py for windows and encoding failures, adjust tests #48117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Oct 21, 2024
|
|
||
| p = PopenSpawn("ray debug", encoding="utf-8") | ||
| else: | ||
| p = pexpect.spawn("ray debug") |
There was a problem hiding this comment.
pexpect.spawn does not work on windows, pexpect.PopenSpawn does work on windows.
mattip
commented
Oct 21, 2024
| self._send = lambda data: connection.sendall(data.encode(fh.encoding)) | ||
| self._send = lambda data: connection.sendall( | ||
| data.encode(fh.encoding, errors="replace") | ||
| ) |
There was a problem hiding this comment.
The errors='replace' is needed since the debugger goes through sys.stdout, which on windows and python<3.15 will use a locale encoding. On my machine it is cp1252, which cannot represent the unicode character in test_ray_debugger_commands
mattip
commented
Oct 21, 2024
| # in tests, when using pexpect, the pipe makes | ||
| # the msvcrt.kbhit() trick fail. Assume we are waiting | ||
| # for stdin, since this will block waiting for input | ||
| ready_to_read.append(sys.stdin) |
There was a problem hiding this comment.
This was annoying to debug. In the test, pexpect uses a PIPE to communicate over sys.stdin which does not work correctly with msvcrt.kbhit(). "Normal" ray debug use will not enter this clause, sys.stdin.isatty() will be True
mattip
force-pushed
the
windows-debugger
branch
from
337b059 to
e9bbcb5
Compare
|
cc @anyscalesam |
jcotant1
added
core
Signed-off-by: Matti Picus <matti.picus@gmail.com>
Signed-off-by: mattip <matti.picus@gmail.com>
mattip
force-pushed
the
windows-debugger
branch
from
e9bbcb5 to
5ec514e
Compare
|
I rebased this on master to clear the merge conflicts. cc @jjyao |
|
Ping |
jjyao
approved these changes
Dec 10, 2024
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 12, 2024
…ay-project#48117) Signed-off-by: Matti Picus <matti.picus@gmail.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
…ay-project#48117) Signed-off-by: Matti Picus <matti.picus@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Enables
ray debugon windows. Fixes #44902. Fixes #37145. Also changes tests to work on windows.Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.