Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][compiled graph] remove dead code #48282

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[core][compiled graph] remove dead code #48282

merged 1 commit into from
Oct 29, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 26, 2024 •
edited
Loading

Why are these changes needed?

If args is not a list, an exception will be thrown in the above if statement.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421
remove dead code
744d107 
Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421 kevin85421 marked this pull request as ready for review October 26, 2024 22:47
@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Oct 28, 2024
@rkooo567 rkooo567 merged commit 43c3663 into ray-project:master Oct 29, 2024
5 checks passed
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@kevin85421 @Jay-ju
[core][compiled graph] remove dead code (ray-project#48282)
05ce0d9 
If args is not a list, an exception will be thrown in the above if statement.
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@kevin85421 @JP-sDEV
[core][compiled graph] remove dead code (ray-project#48282)
92681f9 
If args is not a list, an exception will be thrown in the above if statement.

Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@kevin85421 @mohitjain2504
[core][compiled graph] remove dead code (ray-project#48282)
7d1f84c 
If args is not a list, an exception will be thrown in the above if statement.

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisearch42 ruisearch42 ruisearch42 approved these changes

Assignees

@rkooo567 rkooo567

@ruisearch42 ruisearch42

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin85421 @ruisearch42 @rkooo567