Revert "[serve] Remove ability to specify route_prefix at deployment level"
#48292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t level …" This reverts commit 90e6e72.
can-anyscale
requested review from
edoakes,
zcin,
GeneDer,
akshay-anyscale and
a team
as code owners
edoakes
added a commit
to edoakes/ray
that referenced
this pull request
Oct 28, 2024
…eployment level" (ray-project#48292)" This reverts commit 703194a. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
added a commit
that referenced
this pull request
Oct 29, 2024
…eployment level" (#48292)" (#48294) This reverts commit 703194a. The original commit caused `test_deploy_2.py` to become flaky. It appears this was a timing issue due to the 10s timeout set on the test. I've removed this, as it looks like a very old test case that is no longer relevant. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…t level" (ray-project#48292) Reverts ray-project#48223 Broke ray-project#48289 so revert to unblock the release.
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…eployment level" (ray-project#48292)" (ray-project#48294) This reverts commit 703194a. The original commit caused `test_deploy_2.py` to become flaky. It appears this was a timing issue due to the 10s timeout set on the test. I've removed this, as it looks like a very old test case that is no longer relevant. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…t level" (ray-project#48292) Reverts ray-project#48223 Broke ray-project#48289 so revert to unblock the release. Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…eployment level" (ray-project#48292)" (ray-project#48294) This reverts commit 703194a. The original commit caused `test_deploy_2.py` to become flaky. It appears this was a timing issue due to the 10s timeout set on the test. I've removed this, as it looks like a very old test case that is no longer relevant. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…t level" (ray-project#48292) Reverts ray-project#48223 Broke ray-project#48289 so revert to unblock the release. Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…eployment level" (ray-project#48292)" (ray-project#48294) This reverts commit 703194a. The original commit caused `test_deploy_2.py` to become flaky. It appears this was a timing issue due to the 10s timeout set on the test. I've removed this, as it looks like a very old test case that is no longer relevant. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #48223
Broke #48289 so revert to unblock the release.