Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag #48433

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

stephanie-wang
Copy link
Contributor

@stephanie-wang stephanie-wang commented Oct 30, 2024

Why are these changes needed?

Reduce the actors needed for test_mocked_nccl_dag test.

Closes #48288.

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
@stephanie-wang stephanie-wang added the go add ONLY when ready to merge, run all tests label Oct 30, 2024
@stephanie-wang stephanie-wang changed the title [WIP] Fix flaky test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky Fix flaky test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag Oct 30, 2024
@stephanie-wang stephanie-wang merged commit 956310d into ray-project:master Oct 30, 2024
5 checks passed
@stephanie-wang stephanie-wang deleted the fix-48288 branch October 30, 2024 06:03
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
…nccl_dag (ray-project#48433)

Reduce the actors needed for test_mocked_nccl_dag test.

Closes ray-project#48288.

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…nccl_dag (ray-project#48433)

Reduce the actors needed for test_mocked_nccl_dag test.

Closes ray-project#48288.

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…nccl_dag (ray-project#48433)

Reduce the actors needed for test_mocked_nccl_dag test.

Closes ray-project#48288.

Signed-off-by: Stephanie Wang <smwang@cs.washington.edu>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test linux://python/ray/dag:tests/experimental/test_mocked_nccl_dag is flaky
4 participants