[serve] Add deployment handle dependency injection to build_app
#48447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…y-project#48447) Adds dependency injection to create a custom `DeploymentHandle` type in `build_app`. This will be used to create a special type of handle for local testing mode. This also allowed me to remove the mocking/patching happening in the unit tests. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…y-project#48447) Adds dependency injection to create a custom `DeploymentHandle` type in `build_app`. This will be used to create a special type of handle for local testing mode. This also allowed me to remove the mocking/patching happening in the unit tests. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…y-project#48447) Adds dependency injection to create a custom `DeploymentHandle` type in `build_app`. This will be used to create a special type of handle for local testing mode. This also allowed me to remove the mocking/patching happening in the unit tests. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds dependency injection to create a custom
DeploymentHandletype inbuild_app. This will be used to create a special type of handle for local testing mode.This also allowed me to remove the mocking/patching happening in the unit tests.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.