[Data] Add BundleQueue abstraction
#48503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
bveeramani
requested review from
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
alexeykudinkin
approved these changes
Nov 1, 2024
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
frances720
added a commit
to Promptless/ray-test
that referenced
this pull request
Nov 5, 2024
8 tasks
bveeramani
added a commit
that referenced
this pull request
Nov 5, 2024
Follow-up to #48503. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
Two reasons for adding this abstraction: 1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy. 2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
Follow-up to ray-project#48503. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
bveeramani
added a commit
that referenced
this pull request
Nov 6, 2024
This reverts commit fab26e1. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
bveeramani
added a commit
that referenced
this pull request
Nov 7, 2024
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
bveeramani
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit 4a9c424. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Two reasons for adding this abstraction: 1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy. 2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Follow-up to ray-project#48503. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…y-project#48612) Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…)" (ray-project#48612)" (ray-project#48686) This reverts commit 4a9c424. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
Two reasons for adding this abstraction: 1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy. 2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
Follow-up to ray-project#48503. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…y-project#48612) Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…)" (ray-project#48612)" (ray-project#48686) This reverts commit 4a9c424. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…)" (ray-project#48612)" (ray-project#48686) This reverts commit 4a9c424. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Two reasons for adding this abstraction:
OpRuntimeMetricsso that we can refresh stale bundle sizes.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.