Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Forward fix broken release test due to old config args being used. #48563

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[RLlib] Forward fix broken release test due to old config args being used. #48563

merged 1 commit into from
Nov 5, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 5, 2024 •
edited
Loading

Forward fix broken release test due to old config args being used.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
21cc692 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) November 5, 2024 16:29
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 5, 2024
@can-anyscale can-anyscale disabled auto-merge November 5, 2024 17:19
@can-anyscale can-anyscale merged commit 12e58ab into ray-project:master Nov 5, 2024
5 of 6 checks passed
@sven1977 sven1977 deleted the forward_fix_num_rollout_workers_error branch November 5, 2024 18:57
aslonnie added a commit that referenced this pull request Nov 5, 2024
@aslonnie
cherrypick #48563 and #48527
3faf6fd 
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie added a commit that referenced this pull request Nov 5, 2024
@aslonnie
cherrypick #48563 and #48527 (#48574)
5a6c335 
fixes rllib release tests and mac debugger test

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@sven1977 @JP-sDEV
[RLlib] Forward fix broken release test due to old config args being …
f5ee86a 
…used. (ray-project#48563)

Forward fix broken release test due to old config args being used.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@sven1977 @mohitjain2504
[RLlib] Forward fix broken release test due to old config args being …
755cacd 
…used. (ray-project#48563)

Forward fix broken release test due to old config args being used.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@can-anyscale can-anyscale

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @can-anyscale