Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Refine schedule visualization #48594

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ruisearch42
Copy link
Contributor

@ruisearch42 ruisearch42 commented Nov 6, 2024

Why are these changes needed?

To make the visualization more concise and easier to read:
Show nodes in concise form and show actor information in the subgraph instead.

Visualization

Old:
old

New:
compiled_graph_schedule

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Show nodes in concise form and show actor information
in the subgraph instead.

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42 ruisearch42 marked this pull request as ready for review November 6, 2024 07:09
@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Nov 6, 2024
@kevin85421 kevin85421 self-assigned this Nov 6, 2024
@rkooo567 rkooo567 merged commit 3b2e13b into ray-project:master Nov 7, 2024
6 checks passed
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
)

To make the visualization more concise and easier to read:
Show nodes in concise form and show actor information in the subgraph instead.
Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
)

To make the visualization more concise and easier to read:
Show nodes in concise form and show actor information in the subgraph instead.

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants