Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] [4/N] Package manager uv supports requirement file #48619

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Nov 7, 2024

This PR implements requirement-based dependency list.

@dentiny dentiny requested review from jjyao and rynewang November 7, 2024 01:48
@dentiny dentiny force-pushed the hjiang/uv-requirements branch from 230d0a2 to e7ddab6 Compare November 7, 2024 01:50
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Nov 7, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny force-pushed the hjiang/uv-requirements branch from e7ddab6 to 40f4bc9 Compare November 7, 2024 05:17
@jjyao
Copy link
Collaborator

jjyao commented Nov 8, 2024

Can you change the PR title and description. This PR just adds validation for requirement file.

@dentiny
Copy link
Contributor Author

dentiny commented Nov 8, 2024

Can you change the PR title and description. This PR just adds validation for requirement file.

PR description updated.

Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny
Copy link
Contributor Author

dentiny commented Nov 8, 2024

@jjyao As discussed offline, integration test added.

@jjyao jjyao merged commit 871d4d0 into ray-project:master Nov 8, 2024
5 checks passed
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…t#48619)

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants