Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Refactors WorkerPool with Prestarts. #48677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[core] Refactors WorkerPool with Prestarts. #48677

wants to merge 2 commits into from

Conversation

rynewang
Copy link
Contributor

Refactors WorkerPool and adds an extra PrestartWorkers API.

Changes:

  1. PopWorkerRequest now has a new field to let the started idle worker to keep-alive for a duration. After the duration, or after it's assigned a task, the keep-alive is lifted and it can be idle-killed.
  2. Make the WorkerPool process more clear: now we have distinct PopWorker -> StartNewWorker -> StartWorkerProcess with their differences documented.
  3. Adds a NodeManagerService.PrestartWorkers gRPC method. Callers can ask to prestart num_workers workers, capped by RAY_restart_workers_api_max_num_workers, with runtime_env and job_id.

@rynewang
[core] Refactor WorkerPool with Prestarts.
ba2db76 
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
@rynewang
fix
d4e2660 
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jjyao jjyao

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rynewang @jjyao