-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Minor cpp improvement #48734
Merged
rynewang
merged 10 commits into
ray-project:master
from
dentiny:hjiang/minor-cpp-improvement-nov-13
Nov 15, 2024
Merged
[core] Minor cpp improvement #48734
rynewang
merged 10 commits into
ray-project:master
from
dentiny:hjiang/minor-cpp-improvement-nov-13
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
rynewang
reviewed
Nov 14, 2024
Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: dentiny <dentinyhao@gmail.com>
dentiny
force-pushed
the
hjiang/minor-cpp-improvement-nov-13
branch
from
November 14, 2024 03:19
7e7de7c
to
fde4299
Compare
rynewang
reviewed
Nov 14, 2024
rynewang
approved these changes
Nov 15, 2024
dentiny
added a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
Some C++ improvements to our codebase. --------- Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some C++ improvements to our codebase.