Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fine tune llama with trainium #48768

Merged
merged 7 commits into from
Nov 21, 2024
Merged

docs: fine tune llama with trainium #48768

merged 7 commits into from
Nov 21, 2024

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Nov 16, 2024

Introduce a new Ray Train example for AWS Trainium.

CleanShot 2024-11-16 at 12 48 57@2x

Marked it as a community example as it is something we are collaborating with AWS Neuron team.

CleanShot 2024-11-16 at 12 48 37@2x

Docs screenshots

Screenshot 2024-11-20 at 11 19 39 AM Screenshot 2024-11-20 at 11 19 47 AM Screenshot 2024-11-20 at 11 19 54 AM

Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
Copy link

@sindhupalakodety sindhupalakodety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-ray-zhang Please review the feedback and reach out in case of any questions.

doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
@chris-ray-zhang chris-ray-zhang marked this pull request as ready for review November 20, 2024 19:21
@chris-ray-zhang chris-ray-zhang added the go add ONLY when ready to merge, run all tests label Nov 20, 2024
Copy link

@sindhupalakodety sindhupalakodety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-ray-zhang Please review the feedback

doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style nits.

doc/source/train/examples.yml Outdated Show resolved Hide resolved
doc/source/train/examples.yml Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
doc/source/train/examples/aws-trainium/llama3.rst Outdated Show resolved Hide resolved
@angelinalg angelinalg merged commit bc8ae37 into master Nov 21, 2024
5 checks passed
@angelinalg angelinalg deleted the saihaj/aws-trainium branch November 21, 2024 20:09
chris-ray-zhang added a commit to chris-ray-zhang/ray that referenced this pull request Nov 21, 2024
Introduce a new Ray Train example for AWS Trainium. 

![CleanShot 2024-11-16 at 12 48
57@2x](https://github.com/user-attachments/assets/8b7d12d8-846f-497f-ba25-fd8a613f9007)

Marked it as a community example as it is something we are collaborating
with AWS Neuron team.

![CleanShot 2024-11-16 at 12 48
37@2x](https://github.com/user-attachments/assets/589d8ff3-fcb6-4b90-865d-006bcb4815a3)

Docs screenshots

<img width="1142" alt="Screenshot 2024-11-20 at 11 19 39 AM"
src="https://github.com/user-attachments/assets/aa3dadf7-96b9-46cc-8b6d-44c3e3bc3e1e">
<img width="1161" alt="Screenshot 2024-11-20 at 11 19 47 AM"
src="https://github.com/user-attachments/assets/859508fd-e47e-4758-a4c7-f15a749ece82">
<img width="1149" alt="Screenshot 2024-11-20 at 11 19 54 AM"
src="https://github.com/user-attachments/assets/28858f36-8cca-4eaa-a8ec-a1f7dda899d0">

---------

Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
Co-authored-by: Chris Zhang <chris@anyscale.com>
can-anyscale pushed a commit that referenced this pull request Nov 22, 2024
Introduce a new Ray Train example for AWS Trainium. 

![CleanShot 2024-11-16 at 12 48

57@2x](https://github.com/user-attachments/assets/8b7d12d8-846f-497f-ba25-fd8a613f9007)

Marked it as a community example as it is something we are collaborating
with AWS Neuron team.

![CleanShot 2024-11-16 at 12 48

37@2x](https://github.com/user-attachments/assets/589d8ff3-fcb6-4b90-865d-006bcb4815a3)

Docs screenshots

<img width="1142" alt="Screenshot 2024-11-20 at 11 19 39 AM"
src="https://github.com/user-attachments/assets/aa3dadf7-96b9-46cc-8b6d-44c3e3bc3e1e">
<img width="1161" alt="Screenshot 2024-11-20 at 11 19 47 AM"
src="https://github.com/user-attachments/assets/859508fd-e47e-4758-a4c7-f15a749ece82">
<img width="1149" alt="Screenshot 2024-11-20 at 11 19 54 AM"
src="https://github.com/user-attachments/assets/28858f36-8cca-4eaa-a8ec-a1f7dda899d0">

---------

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
Co-authored-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
MortalHappiness pushed a commit to MortalHappiness/ray that referenced this pull request Nov 22, 2024
Introduce a new Ray Train example for AWS Trainium. 

![CleanShot 2024-11-16 at 12 48
57@2x](https://github.com/user-attachments/assets/8b7d12d8-846f-497f-ba25-fd8a613f9007)

Marked it as a community example as it is something we are collaborating
with AWS Neuron team.

![CleanShot 2024-11-16 at 12 48
37@2x](https://github.com/user-attachments/assets/589d8ff3-fcb6-4b90-865d-006bcb4815a3)

Docs screenshots

<img width="1142" alt="Screenshot 2024-11-20 at 11 19 39 AM"
src="https://github.com/user-attachments/assets/aa3dadf7-96b9-46cc-8b6d-44c3e3bc3e1e">
<img width="1161" alt="Screenshot 2024-11-20 at 11 19 47 AM"
src="https://github.com/user-attachments/assets/859508fd-e47e-4758-a4c7-f15a749ece82">
<img width="1149" alt="Screenshot 2024-11-20 at 11 19 54 AM"
src="https://github.com/user-attachments/assets/28858f36-8cca-4eaa-a8ec-a1f7dda899d0">

---------

Signed-off-by: Saihajpreet Singh <c-saihajpreet.singh@anyscale.com>
Co-authored-by: Chris Zhang <chris@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants