Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] [1/N] Util functions to setup cgroup preparation #48828

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Nov 21, 2024

Required PR for #48788

This PR setup necessary environment for cgroup related operations, including:

  • Create dedicated cgroup for system components
  • Allow cgroup update via subtree control

The util function is written in C++, since I imagine it to be called from main function for raylet and GCS.

Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny requested a review from jjyao December 3, 2024 02:11
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Dec 6, 2024
Signed-off-by: hjiang <dentinyhao@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

src/ray/raylet/cgroup_setup.cc Outdated Show resolved Hide resolved
src/ray/raylet/cgroup_setup.cc Outdated Show resolved Hide resolved
Signed-off-by: hjiang <dentinyhao@gmail.com>
Signed-off-by: hjiang <dentinyhao@gmail.com>
@jjyao jjyao merged commit 08a8dcc into ray-project:master Dec 10, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
…48828)

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
rynewang pushed a commit that referenced this pull request Jan 7, 2025
Before we prepare cgroup V2 environment at
#48828 and setup cgroup for
process at #48788, we should
first check whether cgroupv2 is properly mounted.

---------

Signed-off-by: dentiny <dentinyhao@gmail.com>
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 9, 2025
Before we prepare cgroup V2 environment at
ray-project#48828 and setup cgroup for
process at ray-project#48788, we should
first check whether cgroupv2 is properly mounted.

---------

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
HYLcool pushed a commit to HYLcool/ray that referenced this pull request Jan 13, 2025
Before we prepare cgroup V2 environment at
ray-project#48828 and setup cgroup for
process at ray-project#48788, we should
first check whether cgroupv2 is properly mounted.

---------

Signed-off-by: dentiny <dentinyhao@gmail.com>
Signed-off-by: lielin.hyl <lielin.hyl@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants