[core] Remove gcs InternalConfigTable #49152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <dhyey2019@gmail.com>
dayshah
changed the title
dayshah
commented
Dec 8, 2024
| io_context_provider_.GetDefaultIOContext().run(); | ||
| // Reset the main service to the initial status otherwise, the signal handler | ||
| // will be called. | ||
| io_context_provider_.GetDefaultIOContext().restart(); |
There was a problem hiding this comment.
assuming the io context also doesn't have to be restarted now
Signed-off-by: dayshah <dhyey2019@gmail.com>
dentiny
approved these changes
Dec 8, 2024
clangd just shows me with unused-includes |
Signed-off-by: dayshah <dhyey2019@gmail.com>
jjyao
approved these changes
Dec 9, 2024
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
GCS InternalConfigTable is actually unused now. It was only used for the raylet_config_list before and now that's stored directly as a member of GcsInternalKVManager and HandleGetInternalConfig directly returns the raylet_config_list that was stored as a member variable.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.