Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Add ExecutionCallback interface #49205

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented Dec 11, 2024

Why are these changes needed?

Add an ExecutionCallback interface to allow hooking custom callback logic into certain execution events. This can be useful for optimization rules.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen raulchen requested a review from a team as a code owner December 11, 2024 05:55
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@srinathk10
Copy link
Contributor

Nice! We have a Prepare, Commit/Abort hook. LGTM!

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen enabled auto-merge (squash) December 11, 2024 22:25
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 11, 2024
@raulchen raulchen merged commit b3e4e82 into ray-project:master Dec 11, 2024
6 of 7 checks passed
@raulchen raulchen deleted the execution-callback branch December 12, 2024 00:31
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 12, 2024
## Why are these changes needed?

Add an ExecutionCallback interface to allow hooking custom callback
logic into certain execution events. This can be useful for optimization
rules.

---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
## Why are these changes needed?

Add an ExecutionCallback interface to allow hooking custom callback
logic into certain execution events. This can be useful for optimization
rules.

---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants