Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI; RLlib] Increase parallel example scripts processes from 5 to 6. #49217

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[CI; RLlib] Increase parallel example scripts processes from 5 to 6. #49217

merged 3 commits into from
Dec 11, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 11, 2024 •
edited
Loading

Increase parallel example scripts processes from 5 to 6.

  • More old API stack cleanups (remove further outdated files and test cases).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
d28fb88 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
simonsays1980 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977
wip
d6f54cd 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack ci-test labels Dec 11, 2024
@sven1977 sven1977 enabled auto-merge (squash) December 11, 2024 15:44
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 11, 2024
@sven1977
wip
7b54467 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 requested review from maxpumperla and a team as code owners December 11, 2024 16:26
@github-actions github-actions bot disabled auto-merge December 11, 2024 16:26
@sven1977 sven1977 enabled auto-merge (squash) December 11, 2024 16:27
@sven1977 sven1977 merged commit 644b594 into ray-project:master Dec 11, 2024
6 checks passed
@sven1977 sven1977 deleted the increase_example_script_ci_workers_to_6 branch December 11, 2024 18:27
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 12, 2024
@sven1977 @simonsays1980
[CI; RLlib] Increase parallel example scripts processes from 5 to 6. (r…
a90aa29 
…ay-project#49217)
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
@sven1977 @ujjawal-khare
[CI; RLlib] Increase parallel example scripts processes from 5 to 6. (r…
91315ef 
…ay-project#49217)

Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
ci-test go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980