[Serve] Deflake test_reconfigure_with_queries
#49696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
edoakes
reviewed
Jan 7, 2025
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
edoakes
reviewed
Jan 8, 2025
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
Signed-off-by: Josh Karpel <josh.karpel@gmail.com>
|
@edoakes looks like there's an unrelated problem in CI? https://buildkite.com/ray-project/microcheck/builds/9567#019447cc-7e4f-47da-8184-3ad36200afb4 |
Yeah have been seeing this today... should get fixed soon. Will just need to re-run once it does. |
edoakes
approved these changes
Jan 8, 2025
|
My pleasure! Thanks for reviewing, appreciate the tips on the helper functions! |
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
Small isolated PR to (hopefully) fix flakiness issues with `python/ray/serve/tests/test_deploy.py::test_reconfigure_with_queries`, noticed while working on ray-project#48807 and other PRs. --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
dayshah
pushed a commit
to dayshah/ray
that referenced
this pull request
Jan 10, 2025
Small isolated PR to (hopefully) fix flakiness issues with `python/ray/serve/tests/test_deploy.py::test_reconfigure_with_queries`, noticed while working on ray-project#48807 and other PRs. --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
HYLcool
pushed a commit
to HYLcool/ray
that referenced
this pull request
Jan 13, 2025
Small isolated PR to (hopefully) fix flakiness issues with `python/ray/serve/tests/test_deploy.py::test_reconfigure_with_queries`, noticed while working on ray-project#48807 and other PRs. --------- Signed-off-by: Josh Karpel <josh.karpel@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: lielin.hyl <lielin.hyl@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Small isolated PR to (hopefully) fix flakiness issues with
python/ray/serve/tests/test_deploy.py::test_reconfigure_with_queries, noticed while working on #48807 and other PRs.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.