Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Refactor replica wrapper #49806

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Jan 13, 2025

Why are these changes needed?

Refactor replica wrapper in replica scheduler such that:

  • The class that replica scheduler interacts with is RunningReplica.
  • RunningReplica holds references to wrapper classes (e.g. ActorReplicaWrapper) that handle sending the actual request over the wire to the replicas.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

zcin added 6 commits January 13, 2025 09:15
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin marked this pull request as ready for review January 13, 2025 17:42
@zcin zcin requested review from GeneDer and edoakes January 13, 2025 17:42
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zcin added 3 commits January 13, 2025 10:37
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely looks like something

@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jan 13, 2025
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin merged commit a7b29a5 into ray-project:master Jan 13, 2025
5 checks passed
@zcin zcin deleted the replica-wrapper-refactor branch January 13, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants